Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require file-embed-lzma>=0.1 #115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ysangkok
Copy link
Collaborator

@ysangkok ysangkok commented Jul 3, 2024

This also bumps the versions. Once the tests pass, I will make a release with the modified version numbers.

@ysangkok
Copy link
Collaborator Author

ysangkok commented Jul 3, 2024

I don't have permissions to merge this, and I don't have permissions to upload jensoleg or redoc to Hackage. So I just uploaded servant-swagger-ui. Should address this issue though:

@shinzui
Copy link

shinzui commented Sep 5, 2024

Can we please merge this PR?

@ysangkok
Copy link
Collaborator Author

ysangkok commented Sep 5, 2024

@shinzui It has been updated on Hackage. Unless you're using jensoleg or redoc.

@shinzui
Copy link

shinzui commented Sep 5, 2024

I missed that. Thanks.

@ysangkok
Copy link
Collaborator Author

@tchoutri Could I get permissions to merge this somehow? It's silly that we're requiring tests with old versions of GHC. Now that we removed GHC 8.* from servant, we should also remove it here, which this PR does.

@tchoutri
Copy link

@ysangkok I have bumped your role, you should be able now. :)

@ysangkok ysangkok force-pushed the file-embed-lzma-upgrade branch from 88dcf0a to f48ab8a Compare January 16, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants